Skip to content

refactor: remove unused .slackignore support and dependencies 💀 #309

Merged
mwbrooks merged 2 commits intomainfrom
mwbrooks-rip-slackignore
Jan 26, 2026
Merged

refactor: remove unused .slackignore support and dependencies 💀 #309
mwbrooks merged 2 commits intomainfrom
mwbrooks-rip-slackignore

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Jan 23, 2026 •
edited
Loading

Changelog

Removed support for the .slackignore file in the project root. This file was unused. During the Slack CLI Beta, this allowed Deno SDK projects to ignore files during deployment, but the feature was removed before Slack CLI v1.0.0.

Summary

This pull request removes support for the .slackignore file. While the Slack CLI would read existing a .slackignore file, it never used the contents. Long ago, this feature was intended to ignore packaging Deno Project files for deployment.

Going forward, we would offer configurations such as this in the .slack/config.json file.

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Jan 23, 2026
@mwbrooks mwbrooks self-assigned this Jan 23, 2026
@mwbrooks mwbrooks requested a review from a team as a code owner January 23, 2026 23:10
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment labels Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.84%. Comparing base (158bfa7) to head (d3fa4de).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   64.83%   64.84%   +0.01%     
==========================================
  Files         213      212       -1     
  Lines       17550    17538      -12     
==========================================
- Hits        11379    11373       -6     
+ Misses       5105     5097       -8     
- Partials     1066     1068       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zimeg
zimeg approved these changes Jan 24, 2026
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks What a nice find! And TIL about this past feature! 🪬 ✨

internal/config/slackignore.go
Copy link
Member

@zimeg zimeg Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐊 praise: See ya later aligator!

@mwbrooks
Copy link
Member Author

mwbrooks commented Jan 26, 2026

Thanks for the quick review @zimeg! 🙇🏻 🚢 Bye bye .slackignore 👋🏻

@mwbrooks mwbrooks merged commit 114e011 into main Jan 26, 2026
8 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-rip-slackignore branch January 26, 2026 17:24
@mwbrooks mwbrooks added the changelog Use on updates to be included in the release notes label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@mwbrooks mwbrooks

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Milestone

v3.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mwbrooks @zimeg